Update local-cluster info in MCE doc #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Wu <phwu@redhat.com>
Signed-off-by: Philip Wu <phwu@redhat.com>
Signed-off-by: Philip Wu <phwu@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jnpacker, philipwu08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci bot
pushed a commit
that referenced
this pull request
Jun 28, 2022
* Trigger backplane-2.1 FF (#98) Signed-off-by: Joshua Packer <jpacker@redhat.com> * Verify customized flow for AWS. (#96) 1. Support changing up the AvailabilityPolicy 2. Release.Image 3. NodePool.Spec.Platform.AWS for the node's AMI information 4. NodePool release image. 5. Readme update with a reference to this YAML 6. Fixed some bugs in this flow 7. Fixed a poor condition message when spec.hostingCluster is missing 8. Fixed a bug where we exited during a destroy early, orphaning resources Signed-off-by: Joshua Packer <jpacker@redhat.com> * Bump hypershift-operator to commit [c7c2b57c98ca] (#99) * Trigger backplane-2.1 FF Signed-off-by: Joshua Packer <jpacker@redhat.com> * Bump hypershift-operator to commit c7c2b57c98ca Signed-off-by: Joshua Packer <jpacker@redhat.com> * Override controller-runtime v0.11.2 from v0.12.1 Signed-off-by: Joshua Packer <jpacker@redhat.com> * ObjectRef build support: (#100) * ObjectRef build support: * Add get-hypershift-crds MakeFile target, HostedCluster and NodePool CRDs from openshift/hypershift, using the SHA from go.mod * get-hypershift-crds is called when make manifests is called * Using the go.mod SHA makes sure the CRDs match the openshift/hypershift module Signed-off-by: Joshua Packer <jpacker@redhat.com> * Slight change to the commit_sha variable Signed-off-by: Joshua Packer <jpacker@redhat.com> * Fix CVE-2022-28948 (#101) Signed-off-by: Joshua Packer <jpacker@redhat.com> * Add CRD compare Git Action (#103) * Add CRD compare Git Action Signed-off-by: Joshua Packer <jpacker@redhat.com> * Rename crd-compare.yaml to crd-compare.yml Change yaml to yml * Update crd-compare.yml * Bump go.mod version for hypershift-operator (#102) Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update crd-compare.yml (#104) Add a 9am check * Add slack notification (#105) * Add slack notification Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update crd-compare.yml * Object ref doc (#106) * Remove excess logging Signed-off-by: Philip Wu <phwu@redhat.com> * Add doc for object ref Signed-off-by: Philip Wu <phwu@redhat.com> * Add security constraints to ensure the hosting cluster is a managed cluster and belongs to managedclusterset (#108) Signed-off-by: Mike Ng <ming@redhat.com> * Update owners files. Quick fix to manifestwork security constraints check (#113) Signed-off-by: Mike Ng <ming@redhat.com> * Default the OCP image to 4.10.15 (#114) * Fix a problem when auto-configuring Azure, that we miss the infraId. * Automatically fill the Network podCIDR and serviceCIDR. * Fill the pull secret name if missing Signed-off-by: Joshua Packer <jpacker@redhat.com> * Missed configuring the release image in the nodePool if its missing (#116) * Missed configuring the release image in the nodePool if its missing Signed-off-by: Joshua Packer <jpacker@redhat.com> * The timeout was incorrectly added in the previous acm-1417 merge Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update COMPONENT_VERSION * Validations and checks for hostedcluster and nodepools (#110) * Add validations and cross checks for hostedcluster and nodepools Signed-off-by: Philip Wu <phwu@redhat.com> * Log when ReleaseImage for HostedCluster and NodePool doesn't match Signed-off-by: Philip Wu <phwu@redhat.com> * Remove hostedcluster and nodepool while deleting hyd (#112) * Remove hostedcluster and nodepool while deleting hyd make sure the work agent consumed the delete option changes before deleting the manifestwork Signed-off-by: zhujian <jiazhu@redhat.com> * Fix integration tests Signed-off-by: zhujian <jiazhu@redhat.com> * Use condition generation to make sure the delete option change is consumed Signed-off-by: zhujian <jiazhu@redhat.com> * Force build to check FF (#120) * Update local-cluster info in MCE doc (#122) * Update local-cluster info in MCE doc Signed-off-by: Philip Wu <phwu@redhat.com> * Update hypershift crds Signed-off-by: Philip Wu <phwu@redhat.com> * Update msg in git action Signed-off-by: Philip Wu <phwu@redhat.com> * Add additional testing for deleteManifestworkWaitCleanUp to bring cov… (#121) * Add additional testing for deleteManifestworkWaitCleanUp to bring coverage over 80% Signed-off-by: Joshua Packer <jpacker@redhat.com> * Adjustments Mike suggested. * check the spec setting, should NOT be orphan * uses client.Status().Update Signed-off-by: Joshua Packer <jpacker@redhat.com> * Added check to make sure ManifestWork is still present after first pass, and removed after second pass Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update CRD's, change it prowervs does not apply (#125) Signed-off-by: Joshua Packer <jpacker@redhat.com> * ACM-1420 fix default deployment flow (#126) * ACM-1420 fix default deployment flow * original release image lookup returned, will find 4.11 * Set the default SDN to OVNKubernetes (OpenShiftSDN for 4.11 will be fixed in an upcoming release) * Set the SDN to OpenShiftSDN if the release image is 4.10.X as OVNKubernetes is NOT suppported * Add test to make sure we correctly convert the networkType * Validate both deploy types Signed-off-by: Joshua Packer <jpacker@redhat.com> * Delete cluster.open-cluster-management.io_hypershiftdeployments.yaml * Fix CRDs for consistency checks Signed-off-by: Joshua Packer <jpacker@redhat.com> * Align hypershiftDeployment with upstream Signed-off-by: Joshua Packer <jpacker@redhat.com> * Remove draft from quickstart doc (#127) Signed-off-by: Philip Wu <phwu@redhat.com> * Add a link to the Action result (#133) * Add a link to the Action result Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update the variable names Signed-off-by: Joshua Packer <jpacker@redhat.com> * json adjustment Signed-off-by: Joshua Packer <jpacker@redhat.com> * ACM-1407 spec.infrastructure.cloudProvider should not be optional (#128) * ACM-1407 spec.infrastructure.cloudProvider should not be optional Signed-off-by: Roke Jung <roke@redhat.com> * ACM-1407 spec.infrastructure.cloudProvider should not be optional Signed-off-by: Roke Jung <roke@redhat.com> * update CRDs Signed-off-by: Roke Jung <roke@redhat.com> * validate spec.infrastructure.cloudProvider and test Signed-off-by: Roke Jung <roke@redhat.com> * fix doc Signed-off-by: Roke Jung <roke@redhat.com> * fix crd comparison Signed-off-by: Roke Jung <roke@redhat.com> * update hypershift module Signed-off-by: Roke Jung <roke@redhat.com> * fix crd compare script Signed-off-by: Roke Jung <roke@redhat.com> * Update crd-compare.yml Update the slack message. * ACM-1474 add endpointAccess private support (#134) Signed-off-by: Joshua Packer <jpacker@redhat.com> * Add documentation fixes for provisioning and content (#129) * Noop (#136) Signed-off-by: Joshua Packer <jpacker@redhat.com> * support private mode hosted clusters (#135) * support private mode hosted clusters Signed-off-by: Roke Jung <roke@redhat.com> * remove unused function Signed-off-by: Roke Jung <roke@redhat.com> * Add AWS multi zone support (#137) * Add AWS multi zone support Signed-off-by: Roke Jung <roke@redhat.com> * Add AWS multi zone support test fix Signed-off-by: Roke Jung <roke@redhat.com> * code review comments 1 Signed-off-by: Roke Jung <roke@redhat.com> * fix test Signed-off-by: Roke Jung <roke@redhat.com> * Modify the default image to 4.10.18, so that import will work with MCE/ACM Signed-off-by: Joshua Packer <jpacker@redhat.com> Co-authored-by: Philip Wu <81585886+philipwu08@users.noreply.github.com> Co-authored-by: Mike Ng <ming@redhat.com> Co-authored-by: Jian Zhu <36154065+zhujian7@users.noreply.github.com> Co-authored-by: Roke Jung <roke@redhat.com> Co-authored-by: Adel Zaalouk <adel.zalok.89@gmail.com>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Trigger backplane-2.1 FF (#98) Signed-off-by: Joshua Packer <jpacker@redhat.com> * Verify customized flow for AWS. (#96) 1. Support changing up the AvailabilityPolicy 2. Release.Image 3. NodePool.Spec.Platform.AWS for the node's AMI information 4. NodePool release image. 5. Readme update with a reference to this YAML 6. Fixed some bugs in this flow 7. Fixed a poor condition message when spec.hostingCluster is missing 8. Fixed a bug where we exited during a destroy early, orphaning resources Signed-off-by: Joshua Packer <jpacker@redhat.com> * Bump hypershift-operator to commit [c7c2b57c98ca] (#99) * Trigger backplane-2.1 FF Signed-off-by: Joshua Packer <jpacker@redhat.com> * Bump hypershift-operator to commit c7c2b57c98ca Signed-off-by: Joshua Packer <jpacker@redhat.com> * Override controller-runtime v0.11.2 from v0.12.1 Signed-off-by: Joshua Packer <jpacker@redhat.com> * ObjectRef build support: (#100) * ObjectRef build support: * Add get-hypershift-crds MakeFile target, HostedCluster and NodePool CRDs from openshift/hypershift, using the SHA from go.mod * get-hypershift-crds is called when make manifests is called * Using the go.mod SHA makes sure the CRDs match the openshift/hypershift module Signed-off-by: Joshua Packer <jpacker@redhat.com> * Slight change to the commit_sha variable Signed-off-by: Joshua Packer <jpacker@redhat.com> * Fix CVE-2022-28948 (#101) Signed-off-by: Joshua Packer <jpacker@redhat.com> * Add CRD compare Git Action (#103) * Add CRD compare Git Action Signed-off-by: Joshua Packer <jpacker@redhat.com> * Rename crd-compare.yaml to crd-compare.yml Change yaml to yml * Update crd-compare.yml * Bump go.mod version for hypershift-operator (#102) Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update crd-compare.yml (#104) Add a 9am check * Add slack notification (#105) * Add slack notification Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update crd-compare.yml * Object ref doc (#106) * Remove excess logging Signed-off-by: Philip Wu <phwu@redhat.com> * Add doc for object ref Signed-off-by: Philip Wu <phwu@redhat.com> * Add security constraints to ensure the hosting cluster is a managed cluster and belongs to managedclusterset (#108) Signed-off-by: Mike Ng <ming@redhat.com> * Update owners files. Quick fix to manifestwork security constraints check (#113) Signed-off-by: Mike Ng <ming@redhat.com> * Default the OCP image to 4.10.15 (#114) * Fix a problem when auto-configuring Azure, that we miss the infraId. * Automatically fill the Network podCIDR and serviceCIDR. * Fill the pull secret name if missing Signed-off-by: Joshua Packer <jpacker@redhat.com> * Missed configuring the release image in the nodePool if its missing (#116) * Missed configuring the release image in the nodePool if its missing Signed-off-by: Joshua Packer <jpacker@redhat.com> * The timeout was incorrectly added in the previous acm-1417 merge Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update COMPONENT_VERSION * Validations and checks for hostedcluster and nodepools (#110) * Add validations and cross checks for hostedcluster and nodepools Signed-off-by: Philip Wu <phwu@redhat.com> * Log when ReleaseImage for HostedCluster and NodePool doesn't match Signed-off-by: Philip Wu <phwu@redhat.com> * Remove hostedcluster and nodepool while deleting hyd (#112) * Remove hostedcluster and nodepool while deleting hyd make sure the work agent consumed the delete option changes before deleting the manifestwork Signed-off-by: zhujian <jiazhu@redhat.com> * Fix integration tests Signed-off-by: zhujian <jiazhu@redhat.com> * Use condition generation to make sure the delete option change is consumed Signed-off-by: zhujian <jiazhu@redhat.com> * Force build to check FF (#120) * Update local-cluster info in MCE doc (#122) * Update local-cluster info in MCE doc Signed-off-by: Philip Wu <phwu@redhat.com> * Update hypershift crds Signed-off-by: Philip Wu <phwu@redhat.com> * Update msg in git action Signed-off-by: Philip Wu <phwu@redhat.com> * Add additional testing for deleteManifestworkWaitCleanUp to bring cov… (#121) * Add additional testing for deleteManifestworkWaitCleanUp to bring coverage over 80% Signed-off-by: Joshua Packer <jpacker@redhat.com> * Adjustments Mike suggested. * check the spec setting, should NOT be orphan * uses client.Status().Update Signed-off-by: Joshua Packer <jpacker@redhat.com> * Added check to make sure ManifestWork is still present after first pass, and removed after second pass Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update CRD's, change it prowervs does not apply (#125) Signed-off-by: Joshua Packer <jpacker@redhat.com> * ACM-1420 fix default deployment flow (#126) * ACM-1420 fix default deployment flow * original release image lookup returned, will find 4.11 * Set the default SDN to OVNKubernetes (OpenShiftSDN for 4.11 will be fixed in an upcoming release) * Set the SDN to OpenShiftSDN if the release image is 4.10.X as OVNKubernetes is NOT suppported * Add test to make sure we correctly convert the networkType * Validate both deploy types Signed-off-by: Joshua Packer <jpacker@redhat.com> * Delete cluster.open-cluster-management.io_hypershiftdeployments.yaml * Fix CRDs for consistency checks Signed-off-by: Joshua Packer <jpacker@redhat.com> * Align hypershiftDeployment with upstream Signed-off-by: Joshua Packer <jpacker@redhat.com> * Remove draft from quickstart doc (#127) Signed-off-by: Philip Wu <phwu@redhat.com> * Add a link to the Action result (#133) * Add a link to the Action result Signed-off-by: Joshua Packer <jpacker@redhat.com> * Update the variable names Signed-off-by: Joshua Packer <jpacker@redhat.com> * json adjustment Signed-off-by: Joshua Packer <jpacker@redhat.com> * ACM-1407 spec.infrastructure.cloudProvider should not be optional (#128) * ACM-1407 spec.infrastructure.cloudProvider should not be optional Signed-off-by: Roke Jung <roke@redhat.com> * ACM-1407 spec.infrastructure.cloudProvider should not be optional Signed-off-by: Roke Jung <roke@redhat.com> * update CRDs Signed-off-by: Roke Jung <roke@redhat.com> * validate spec.infrastructure.cloudProvider and test Signed-off-by: Roke Jung <roke@redhat.com> * fix doc Signed-off-by: Roke Jung <roke@redhat.com> * fix crd comparison Signed-off-by: Roke Jung <roke@redhat.com> * update hypershift module Signed-off-by: Roke Jung <roke@redhat.com> * fix crd compare script Signed-off-by: Roke Jung <roke@redhat.com> * Update crd-compare.yml Update the slack message. * ACM-1474 add endpointAccess private support (#134) Signed-off-by: Joshua Packer <jpacker@redhat.com> * Add documentation fixes for provisioning and content (#129) * Noop (#136) Signed-off-by: Joshua Packer <jpacker@redhat.com> * support private mode hosted clusters (#135) * support private mode hosted clusters Signed-off-by: Roke Jung <roke@redhat.com> * remove unused function Signed-off-by: Roke Jung <roke@redhat.com> * Add AWS multi zone support (#137) * Add AWS multi zone support Signed-off-by: Roke Jung <roke@redhat.com> * Add AWS multi zone support test fix Signed-off-by: Roke Jung <roke@redhat.com> * code review comments 1 Signed-off-by: Roke Jung <roke@redhat.com> * fix test Signed-off-by: Roke Jung <roke@redhat.com> * Update CRD and generated code based on recent zone changes (#141) Signed-off-by: Mike Ng <ming@redhat.com> * Support using SSH key from the cloud provider secret (#140) * Support using SSH key from the cloud provider secret Signed-off-by: Philip Wu <phwu@redhat.com> * Add unit test to use SSH key from cloud provider secret Signed-off-by: Philip Wu <phwu@redhat.com> * Add doc for SSH keys in the cloud provider secret Signed-off-by: Philip Wu <phwu@redhat.com> * Changes based on review comments Signed-off-by: Philip Wu <phwu@redhat.com> * Add new HD Spec.HostedClusterSet. If populated then validates and sets the newly created managed cluster to that cluserSet (#123) Signed-off-by: Mike Ng <ming@redhat.com> * Use release.image from hostedclusterspec for nodepool (#144) Signed-off-by: Philip Wu <phwu@redhat.com> * update hypershift 4.11 operator and go module (#145) * update hypershift 4.11 operator and go module Signed-off-by: Roke Jung <roke@redhat.com> * update hypershift module Signed-off-by: Roke Jung <roke@redhat.com> * migrate AWS roles to rolesRef ARNs Signed-off-by: Roke Jung <roke@redhat.com> * re-enable hypershift CRD comparison Signed-off-by: Roke Jung <roke@redhat.com> * re-enable hypershift CRD comparison Signed-off-by: Roke Jung <roke@redhat.com> * update component version Signed-off-by: Roke Jung <roke@redhat.com> Co-authored-by: Joshua Packer <jpacker@redhat.com> Co-authored-by: Philip Wu <81585886+philipwu08@users.noreply.github.com> Co-authored-by: Mike Ng <ming@redhat.com> Co-authored-by: Jian Zhu <36154065+zhujian7@users.noreply.github.com> Co-authored-by: Adel Zaalouk <adel.zalok.89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philip Wu phwu@redhat.com
Description of the change(s):
Why do we need this PR:
Issue reference:
Test API/Unit - Success