upgrade framework to v0.9.0 #731
Conversation
haoqing0110
force-pushed
the
br_upgarde-frameowkr
branch
from
99f4d54
to
6f5db22
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_upgarde-frameowkr
branch
from
6f5db22
to
9a41afd
Compare
|
/retest |
|
/retest-required |
|
|
@haoqing0110: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @qiujian16 |
|
need some more ut, the gate fails |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -117,7 +117,7 @@ func (r *ClusterInfoReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
|
|
|||
| err = r.Client.Status().Update(ctx, newClusterInfo) | |||
| if err != nil { | |||
| klog.Error("Failed to update clusterInfo status. error %v", err) | |||
| klog.Error("Failed to update clusterInfo status. error %w", err) | |||
There was a problem hiding this comment.
The "SonarCloud Code Analysis" points to this line as 0 coverage on new code, can we just force merge this PR?
Ref: open-cluster-management-io/ocm#355