Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finalizer error when propagating subscriptions #623

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

golanshabi
Copy link

Removed finalizers when propagating subscriptions to managed clusters

Removed finalizers when propagating subscriptions to managed clusters
@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2021

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@golanshabi golanshabi changed the title Update hub.go Fix the finalizer error when propagating subscriptions Dec 21, 2021
@golanshabi golanshabi changed the title Fix the finalizer error when propagating subscriptions Fix finalizer error when propagating subscriptions Dec 21, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mikeshng
Copy link
Contributor

Thank you for the PR. Could you sign your commit please?

git commit -s --amend
git push -f _the_rest_of_the_command_ 

@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: golanshabi, rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiangjingli xiangjingli merged commit 9166413 into stolostron:release-2.3 Dec 22, 2021
@openshift-ci openshift-ci bot mentioned this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants