Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Git SSH known hosts #779

Merged
merged 1 commit into from
Jul 6, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions pkg/utils/gitrepo.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,22 @@ func getConnectionOptions(cloneOptions *GitCloneOption, primary bool) (connectio

options := &git.CloneOptions{
URL: channelConnOptions.RepoURL,
SingleBranch: true,
RecurseSubmodules: git.DefaultSubmoduleRecursionDepth,
ReferenceName: cloneOptions.Branch,
}

// The destination directory needs to be created here
err = os.RemoveAll(cloneOptions.DestDir)

if err != nil {
klog.Warning(err, "Failed to remove directory ", cloneOptions.DestDir)
}

err = os.MkdirAll(cloneOptions.DestDir, os.ModePerm)

if err != nil {
return nil, err
}

// If branch name is provided, clone the specified branch only.
Expand Down Expand Up @@ -238,18 +253,6 @@ func getConnectionOptions(cloneOptions *GitCloneOption, primary bool) (connectio
}
}

err = os.RemoveAll(cloneOptions.DestDir)

if err != nil {
klog.Warning(err, "Failed to remove directory ", cloneOptions.DestDir)
}

err = os.MkdirAll(cloneOptions.DestDir, os.ModePerm)

if err != nil {
return nil, err
}

return options, nil
}

Expand Down