Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/multicloud-operators-subscription: #294 #892

Closed
wants to merge 1 commit into from

Conversation

magic-mirror-bot[bot]
Copy link
Contributor

…e are any orphan subscriptionstatus, if there are delete the resources listed inside of them (#294)

Signed-off-by: Mike Ng <ming@redhat.com>

Signed-off-by: Mike Ng <ming@redhat.com>
(cherry picked from commit 383508775b8f1cc7b0fe410a90ac6faa52d350bb)
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign xiangjingli for approval by writing /assign @xiangjingli in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability C 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

74.1% 74.1% Coverage
0.0% 0.0% Duplication

}

if !foundErr {
if err = clt.Delete(ctx, &appsubStatus, &client.DeleteOptions{}); err != nil {

Check warning

Code scanning / SonarCloud

<!--SONAR_ISSUE_KEY:AYTpuEUokOvbhPW_0MCT-->Implicit memory aliasing in for loop. <p>See more on <a href="https://sonarcloud.io/project/issues?id=open-cluster-management_multicloud-operators-subscription&issues=AYTpuEUokOvbhPW_0MCT&open=AYTpuEUokOvbhPW_0MCT&pullRequest=892">SonarCloud</a></p>

<!--SONAR_ISSUE_KEY:AYTpuEUokOvbhPW_0MCT-->Implicit memory aliasing in for loop. <p>See more on <a href="https://sonarcloud.io/project/issues?id=open-cluster-management_multicloud-operators-subscription&issues=AYTpuEUokOvbhPW_0MCT&open=AYTpuEUokOvbhPW_0MCT&pullRequest=892">SonarCloud</a></p>
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2022

@magic-mirror-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud b2cf1b8 link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant