disable the ACM Hub installing on agent by managedcluster label #346
Conversation
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
|
/cc @zhiweiyin318 |
|
/retest |
@morvencao It supports dynamically updating the label value. When the value changed from |
doc/reserved_names/README.md
Outdated
| @@ -7,6 +7,7 @@ Label | Description | |||
| global-hub.open-cluster-management.io/managed-by=`global-hub-operator\|global-hub\|global-hub-agent` | If the value is `global-hub-operator`, it means the resources are created by the global hub operator. The global hub operator watches the resources based on this label. | |||
| global-hub.open-cluster-management.io/local-resource= | This label is added during creating some resources. It is used to identify the resource is only applied to global hub cluster. It won't be transfered to the regional hub clusters. | |||
| global-hub.open-cluster-management.io/agent-deploy-mode = `Hosted\| Default\| None` | This label is used on ManagedCluster.<br>`Hosted` means the HoH agent will be deployed on Hosting cluster.<br>`Default` means the HoH agent will be deployed on managed cluster.<br>`None` means the HoH agent should not be installed. | |||
| global-hub.open-cluster-management.io/hub-cluster-install = `Enabled\| Disabled` | This label is used on ManagedCluster.<br>`Enable` means the Global Hub addon will install ACM Hub on the agent cluster if there isn't found a hub.<br>`Disabled` means the Global Hub won't install ACM Hub on the agent and also as the default value for the label. | |||
There was a problem hiding this comment.
I would expect if this label exists, then install ACM in the managed cluster. if without this label, then skip the installation. I do not care about the value.
|
Can you help to update |
it looks weird if the label is disable but the hub has been installed and will not be removed. maybe it is better to only use the label without value? |
Signed-off-by: myan <myan@redhat.com>
Yes, I removed the value. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: myan myan@redhat.com