Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the cleanup job(addon-predelete) when detaching the regional hub #351

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

yanmxa
Copy link
Member

@yanmxa yanmxa commented Mar 20, 2023

Signed-off-by: myan myan@redhat.com

Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
@yanmxa yanmxa changed the title fixed the cleanup job(addon-predeletion) when detaching the regional hub fixed the cleanup job(addon-predelete) when detaching the regional hub Mar 20, 2023
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.5% 95.5% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: morvencao, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1b69cb0 into stolostron:main Mar 21, 2023
@yanmxa yanmxa deleted the br_detach_finalizer branch March 21, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants