remove global hub finalizer from local resources and managedcluster. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
/test sonarcloud |
yanmxa
force-pushed
the
br_fix_finalizer
branch
from
c9fd3cf
to
33527bd
Compare
yanmxa
changed the title
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
yanmxa
force-pushed
the
br_fix_finalizer
branch
from
ff85373
to
356d677
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
/cc @clyang82 @morvencao |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: https://issues.redhat.com/secure/RapidBoard.jspa?rapidView=16808&quickFilter=105908
finalizerto delete obj from the bundles before, and now we have to depend on thenot found errorto remove the bundle obj so that can be deleted from the database.UIDfor the deleted obj, I have to add a newNamespacednameto the bundle object for retrieval.refs: https://issues.redhat.com/browse/ACM-4597
fixed: Remove the global hub finalizer from managed cluster when deleting the MGH CR #320