-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default producer event handler for kafka protocol #922
Add default producer event handler for kafka protocol #922
Conversation
/override ci/prow/sonarcloud |
@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis, ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/test test-e2e |
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
aff8893
to
2341db9
Compare
|
/override ci/prow/sonarcloud |
@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis, ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ldpliu, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test test-unit |
/retest |
/test test-e2e |
/override "SonarCloud Code Analysis" |
@yanmxa: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
09c09de
into
stolostron:main
Summary
After this cloudevents/sdk-go#1031 patch to the sdk, we must add the producer event handler, otherwise, it may cause a memory leak for the event channel.
Related issue(s)
Fixes #