Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default producer event handler for kafka protocol #922

Merged

Conversation

yanmxa
Copy link
Member

@yanmxa yanmxa commented May 14, 2024

Summary

After this cloudevents/sdk-go#1031 patch to the sdk, we must add the producer event handler, otherwise, it may cause a memory leak for the event channel.

Related issue(s)

Fixes #

@yanmxa
Copy link
Member Author

yanmxa commented May 14, 2024

/override ci/prow/sonarcloud
/override "SonarCloud Code Analysis"

Copy link

openshift-ci bot commented May 14, 2024

@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis, ci/prow/sonarcloud

In response to this:

/override ci/prow/sonarcloud
/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yanmxa
Copy link
Member Author

yanmxa commented May 14, 2024

/retest

@yanmxa
Copy link
Member Author

yanmxa commented May 15, 2024

/test test-e2e

Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
@yanmxa yanmxa force-pushed the br_add_producer_handle_event branch from aff8893 to 2341db9 Compare May 15, 2024 07:05
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@yanmxa
Copy link
Member Author

yanmxa commented May 15, 2024

/override ci/prow/sonarcloud
/override "SonarCloud Code Analysis"

Copy link

openshift-ci bot commented May 15, 2024

@yanmxa: Overrode contexts on behalf of yanmxa: SonarCloud Code Analysis, ci/prow/sonarcloud

In response to this:

/override ci/prow/sonarcloud
/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yanmxa
Copy link
Member Author

yanmxa commented May 15, 2024

/cc @clyang82 @ldpliu

@openshift-ci openshift-ci bot requested review from clyang82 and ldpliu May 15, 2024 08:39
@ldpliu
Copy link
Contributor

ldpliu commented May 15, 2024

/lgtm

Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldpliu, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanmxa
Copy link
Member Author

yanmxa commented May 15, 2024

/test test-unit

@yanmxa
Copy link
Member Author

yanmxa commented May 15, 2024

/retest

@yanmxa
Copy link
Member Author

yanmxa commented May 15, 2024

/test test-e2e

@yanmxa
Copy link
Member Author

yanmxa commented May 15, 2024

/override "SonarCloud Code Analysis"

Copy link

openshift-ci bot commented May 15, 2024

@yanmxa: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • SonarCloud Code Analysis

Only the following failed contexts/checkruns were expected:

  • ci/prow/gofmt
  • ci/prow/images
  • ci/prow/sonarcloud
  • ci/prow/test-e2e
  • ci/prow/test-unit
  • pull-ci-stolostron-multicluster-global-hub-main-gofmt
  • pull-ci-stolostron-multicluster-global-hub-main-images
  • pull-ci-stolostron-multicluster-global-hub-main-sonarcloud
  • pull-ci-stolostron-multicluster-global-hub-main-test-e2e
  • pull-ci-stolostron-multicluster-global-hub-main-test-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 09c09de into stolostron:main May 15, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants