Skip to content

Commit

Permalink
modify endpoint operator
Browse files Browse the repository at this point in the history
Signed-off-by: clyang82 <chuyang@redhat.com>
  • Loading branch information
clyang82 committed Feb 6, 2024
1 parent b47a261 commit 4852140
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"gopkg.in/yaml.v2"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
rbacv1 "k8s.io/api/rbac/v1"
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
apiextensionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
Expand Down Expand Up @@ -447,13 +448,20 @@ func createManifestWorks(
func createUpdateResources(c client.Client, manifests []workv1.Manifest) error {

Check failure on line 448 in operators/multiclusterobservability/controllers/placementrule/manifestwork.go

View workflow job for this annotation

GitHub Actions / Formatters + Linters (Static Analysis) for Go

createUpdateResources - result 0 (error) is always nil (unparam)

Check failure on line 448 in operators/multiclusterobservability/controllers/placementrule/manifestwork.go

View workflow job for this annotation

GitHub Actions / Formatters + Linters (Static Analysis) for Go

createUpdateResources - result 0 (error) is always nil (unparam)
for _, manifest := range manifests {
obj := manifest.RawExtension.Object.(client.Object)
if obj.GetObjectKind().GroupVersionKind().Kind == "ObservabilityAddon" {
continue
}
obj.SetNamespace(config.GetDefaultNamespace())
if obj.GetObjectKind().GroupVersionKind().Kind == "ClusterRoleBinding" {
role := obj.(*rbacv1.ClusterRoleBinding)
role.Subjects[0].Namespace = config.GetDefaultNamespace()
}
err := c.Create(context.TODO(), obj)
if err != nil && !k8serrors.IsAlreadyExists(err) {
log.Error(err, "Failed to create resource", "kind", obj.GetObjectKind().GroupVersionKind().Kind)
return err
}
}

return nil
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,12 @@ func createAllRelatedRes(
failedDeleteOba := false
for _, cluster := range currentClusters {
log.Info("To delete observabilityAddon", "namespace", cluster)
err = deleteObsAddon(c, cluster)
if err != nil {
failedDeleteOba = true
log.Error(err, "Failed to delete observabilityaddon", "namespace", cluster)
if cluster != config.GetDefaultNamespace() {
err = deleteObsAddon(c, cluster)
if err != nil {
failedDeleteOba = true
log.Error(err, "Failed to delete observabilityaddon", "namespace", cluster)
}
}
}

Expand Down

0 comments on commit 4852140

Please sign in to comment.