Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some unused code and docs tidy #1360

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

philipgough
Copy link
Contributor

No description provided.

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Feb 29, 2024

@philipgough: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e d300d7d link true /test test-e2e
ci/prow/e2e-kind d300d7d link true /test e2e-kind

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nit could put all the output stuff in docs into code blocks

Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipgough,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philipgough philipgough merged commit 1b3dc4d into stolostron:main Feb 29, 2024
12 of 15 checks passed
@philipgough philipgough deleted the cleanup-1 branch February 29, 2024 14:50
coleenquadros pushed a commit that referenced this pull request Mar 1, 2024
* ci: Remove unreferenced scripts

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>

* test: Remove unused function call and code

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>

* test: Clean up test script

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>

* docs: Tidy up simulator docs

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>

---------

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@philipgough philipgough mentioned this pull request Mar 4, 2024
sradco pushed a commit to sradco/multicluster-observability-operator that referenced this pull request Mar 17, 2024
* ci: Remove unreferenced scripts

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>

* test: Remove unused function call and code

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>

* test: Clean up test script

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>

* docs: Tidy up simulator docs

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>

---------

Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants