-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-4120 Remove Search V1 CRDs from 2.8 #1003
Conversation
Signed-off-by: Erin Murphy <erinmurp@redhat.com>
@eemurphy How did you test this change? |
@JakobGray I installed 2.6 where there's still search v1, upgraded to 2.7, then changed the image to my dev mch and checked that those 2 crds were gone |
Signed-off-by: Erin Murphy <erinmurp@redhat.com> Co-authored-by: Jakob Gray <20209054+JakobGray@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eemurphy, JakobGray The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* ACM-4120 Remove Search V1 CRDs from 2.8 Signed-off-by: Erin Murphy <erinmurp@redhat.com> * Update controllers/uninstall.go Signed-off-by: Erin Murphy <erinmurp@redhat.com> Co-authored-by: Jakob Gray <20209054+JakobGray@users.noreply.github.com> --------- Signed-off-by: Erin Murphy <erinmurp@redhat.com> Co-authored-by: Jakob Gray <20209054+JakobGray@users.noreply.github.com> Signed-off-by: Xiangjing Li <xiangli@redhat.com>
issue: https://issues.redhat.com/browse/ACM-4120