Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolSync addon controller - clusterrole update https://issues.redhat.com/browse/ACM-10539 #1487

Conversation

tesshuflower
Copy link
Contributor

Description

Cluster role update for the volsync-addon-controller as advised by the addon-framework developers.

Related Issue

https://issues.redhat.com/browse/ACM-10539

Changes Made

Update clusterrole to allow update/patch on clustermanagementaddon/status.

Signed-off-by: Tesshu Flower <tflower@redhat.com>
@tesshuflower
Copy link
Contributor Author

/cherry-pick release-2.10

@openshift-cherrypick-robot

@tesshuflower: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dislbenn
Copy link
Contributor

dislbenn commented May 6, 2024

/lgtm

Copy link

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 86b1cd7 into stolostron:main May 6, 2024
7 checks passed
@openshift-cherrypick-robot

@tesshuflower: new pull request created: #1488

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants