Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pvc policies from backup chart (https://issues.redhat.com/browse/ACM-10745) #1494

Merged
merged 1 commit into from
May 8, 2024

Conversation

birsanv
Copy link
Contributor

@birsanv birsanv commented May 8, 2024

Description

Remove PV backup policies from the backup chart since this does not need to be GA in 2.11
Keep the policies under the policy community project (related to open-cluster-management-io/policy-collection#475 )

Related Issue

https://issues.redhat.com/browse/ACM-10745

Changes Made

  • Removed the 3 policies from the chart
  • Updated policy sets and removed the references to these policies

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
@birsanv
Copy link
Contributor Author

birsanv commented May 8, 2024

/cc @tesshuflower

@openshift-ci openshift-ci bot requested a review from tesshuflower May 8, 2024 17:18
@birsanv
Copy link
Contributor Author

birsanv commented May 8, 2024

/cc @dislbenn

@openshift-ci openshift-ci bot requested a review from dislbenn May 8, 2024 17:24
Copy link
Contributor

@tesshuflower tesshuflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dislbenn
Copy link
Contributor

dislbenn commented May 8, 2024

/lgtm

Copy link

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, dislbenn, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 8, 2024
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@openshift-merge-bot openshift-merge-bot bot merged commit c82c9c3 into stolostron:main May 8, 2024
7 checks passed
@birsanv birsanv deleted the vb_pvc_policies branch May 8, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants