Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix upgrade from 2.6-2.7-2.8 apiservice exist issue #40

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix upgrade from 2.6-2.7-2.8 apiservice exist issue #40

merged 1 commit into from
Jun 5, 2023

Conversation

ldpliu
Copy link

@ldpliu ldpliu commented Jun 5, 2023 •
edited

@ldpliu ldpliu mentioned this pull request Jun 5, 2023
Merged
@ldpliu ldpliu force-pushed the fix-apiservice branch 4 times, most recently from 8910978 to 8a5f46b Compare June 5, 2023 05:45
@ldpliu
Copy link
Author

ldpliu commented Jun 5, 2023

/hold need release manager confirm to merge

qiujian16
qiujian16 reviewed Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved label Jun 5, 2023
@elgnay
Copy link

elgnay commented Jun 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2023
@ldpliu
Copy link
Author

ldpliu commented Jun 5, 2023

/retest

@stolostron stolostron deleted a comment from openshift-ci bot Jun 5, 2023
@openshift-ci openshift-ci bot removed the lgtm label Jun 5, 2023
@elgnay
Copy link

elgnay commented Jun 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2023
@zhiweiyin318
Copy link

/retest e2e

@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2023

@zhiweiyin318: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test e2e
  • /test images
  • /test integration
  • /test unit
  • /test verify
  • /test verify-deps

Use /test all to run all jobs.

In response to this:

/retest e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm label Jun 5, 2023
@ldpliu
fix upgrade from 2.6-2.7-2.8 apiservice exist issue
b15075c 
Signed-off-by: ldpliu <daliu@redhat.com>
@ldpliu
Copy link
Author

ldpliu commented Jun 5, 2023

/unhold

@zhiweiyin318
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, ldpliu, qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qiujian16,zhiweiyin318]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 061788c into stolostron:backplane-2.3 Jun 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiujian16 qiujian16 qiujian16 left review comments

Assignees

@zhiweiyin318 zhiweiyin318

@elgnay elgnay

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
5 participants
@ldpliu @elgnay @zhiweiyin318 @qiujian16 @openshift-merge-robot