Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated namespace metadata in example #6125

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

ngraham20
Copy link

@ngraham20 ngraham20 commented Feb 12, 2024

Signed-off-by: Nathaniel Graham <[nathaniel.graham@protonmail.com, ngraham@redhat.com]>
Copy link

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngraham20, swopebe

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Nathaniel Graham <[nathaniel.graham@protonmail.com, ngraham@redhat.com]>
@openshift-ci openshift-ci bot removed the lgtm label Feb 12, 2024
Copy link

openshift-ci bot commented Feb 12, 2024

New changes are detected. LGTM label has been removed.

@swopebe
Copy link
Contributor

swopebe commented Feb 13, 2024

@ngraham20 since this is work that is labeled by a train, it's not really a "bug" -- is this something we need to mention in the What's new as "new function" (that is how we treat Train doc work) or is it an internal fix that we don't need to mention for GA?

@ngraham20
Copy link
Author

@ngraham20 since this is work that is labeled by a train, it's not really a "bug" -- is this something we need to mention in the What's new as "new function" (that is how we treat Train doc work) or is it an internal fix that we don't need to mention for GA?

Hey @swopebe The train label just describes when the work is intended to be completed. It's a bug, and not "new function", so however you need to treat that on your end is how we should move forward with this

@swopebe swopebe merged commit 4c5680b into stolostron:2.10_stage Feb 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants