[ACM-2.10] ACM#10464: Extracting OpenShift release image digest #6393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrystalChun
reviewed
May 3, 2024
| ---- | ||
|
|
||
| + | ||
| Replace `<hosted-cluster-namespace>` with your hosted cluster namespace name, for example, `clusters`. Replace `<hosted-cluster-name>` with your hosted cluster name. | ||
| Replace `<hosted_cluster_namespace>` with your hosted cluster namespace name, for example, `clusters`. Replace `<hosted-cluster-name>` with your hosted cluster name. |
There was a problem hiding this comment.
Suggested change
| Replace `<hosted_cluster_namespace>` with your hosted cluster namespace name, for example, `clusters`. Replace `<hosted-cluster-name>` with your hosted cluster name. | |
| Replace `<hosted_cluster_namespace>` with your hosted cluster namespace name, for example, `clusters`. Replace `<hosted_cluster_name>` with your hosted cluster name. |
xenolinux
force-pushed
the
hcp-disconnected-10464-210
branch
from
19be2cf
to
8a5d7be
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CrystalChun, xenolinux The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xenolinux
force-pushed
the
hcp-disconnected-10464-210
branch
from
8a5d7be
to
c2be753
Compare
|
New changes are detected. LGTM label has been removed. |
dockerymick
requested changes
May 6, 2024
| @@ -1,51 +1,51 @@ | |||
| [#creating-a-hosted-cluster-bm] | |||
| = Creating a hosted cluster on bare metal | |||
|
|
|||
| You can create a hosted cluster or import one. For instructions to import a hosted cluster, see _Importing a hosted cluster_. | |||
| You can create a hosted cluster on bare metal or import one. For instructions to import a hosted cluster, see _Importing a hosted cluster_. | |||
|
|
|||
| . Create the hosted control plane namespace by entering the following command: | |||
|
|
|||
| + | |||
| ---- | |||
There was a problem hiding this comment.
Suggested change
| ---- | |
| [source,bash] | |
| ---- |
| ---- | ||
|
|
||
| + | ||
| Replace `<hosted-cluster-namespace>` with your hosted cluster namespace name, for example, `clusters`. Replace `<hosted-cluster-name>` with your hosted cluster name. | ||
| Replace `<hosted_cluster_namespace>` with your hosted cluster namespace name, for example, `clusters`. Replace `<hosted_cluster_name>` with your hosted cluster name. | ||
|
|
||
| . Verify that you have a default storage class configured for your cluster. Otherwise, you might see pending PVCs. See the following example: | ||
|
|
||
| + | ||
| ---- |
There was a problem hiding this comment.
similar question from my other review: #6394 (comment)
There was a problem hiding this comment.
This is a continuous one command. Added [source,bash] for this command too.
| <4> Specify your base domain, for example, `krnl.es`. | ||
| <5> Specify the etcd storage class name, for example, `lvm-storageclass`. | ||
| <6> Specify the path to your SSH public key. The default file path is `~/.ssh/id_rsa.pub`. | ||
| <7> Specify your hosted cluster namespace. | ||
| <8> Specify the supported {ocp-short} version that you want to use, for example, `4.14.0-x86_64`. | ||
| <8> Specify the supported {ocp-short} version that you want to use, for example, `4.14.0-x86_64`. If you are using a disconnected environment, replace `<ocp_release_image>` with the digest image. To extract the {ocp-short} release image digest, see _Extracting the {ocp-short} release image digest_. | ||
|
|
||
| + | ||
| . After a few moments, verify that your hosted control plane pods are up and running by entering the following command: | ||
|
|
||
| + | ||
| ---- |
There was a problem hiding this comment.
Suggested change
| ---- | |
| [source,bash] | |
| ---- |
xenolinux
force-pushed
the
hcp-disconnected-10464-210
branch
from
c2be753
to
b2a84f6
Compare
xenolinux
force-pushed
the
hcp-disconnected-10464-210
branch
from
b2a84f6
to
78f7a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ACM-10464
The peer-review approval is present in #6392