Create the addon SA before the deployment #460
Conversation
The agent uses a ManifestWork to deploy the agent on the hub; this ManifestWork is charged with creating the roles, role bindings, service account, and deployment for the addon. In some cases, the deployment fails because the service account hasn't been created by the time the pod replicaset is instantiated. This reorders the ManifestWork entries so that the SA comes first, followed by the roles and bindings, and the deployment comes last. This should ensure that the SA is created before any resource which needs it. Signed-off-by: Stephen Kitt <skitt@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tpantelis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-2.5 |
|
@skitt: once the present PR merges, I will cherry-pick it on top of release-2.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-2.4 |
|
@skitt: once the present PR merges, I will cherry-pick it on top of release-2.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@skitt: new pull request created: #461 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@skitt: new pull request created: #462 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The agent uses a ManifestWork to deploy the agent on the hub; this
ManifestWork is charged with creating the roles, role bindings,
service account, and deployment for the addon. In some cases, the
deployment fails because the service account hasn't been created by
the time the pod replicaset is instantiated.
This reorders the ManifestWork entries so that the SA comes first,
followed by the roles and bindings, and the deployment comes last.
This should ensure that the SA is created before any resource which
needs it.
Signed-off-by: Stephen Kitt skitt@redhat.com