Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon framework updates v0.9.2 https://issues.redhat.com/browse/ACM-10539 #250

Conversation

tesshuflower
Copy link
Collaborator

  • update addon-framework to v0.9.2 for ACM 2.11
  • new unit test to check that the CMA (ClusterManagementAddon) for volsync gets the annotation addon.open-cluster-management.io/lifecycle set to self correctly.

Signed-off-by: Tesshu Flower <tflower@redhat.com>
addon.open-cluster-management.io/lifecycle should be
set to self

For: https://issues.redhat.com/browse/ACM-10539

Signed-off-by: Tesshu Flower <tflower@redhat.com>
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haoqing0110
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 28af93b into stolostron:main May 6, 2024
6 checks passed
@tesshuflower tesshuflower deleted the addon-framework-updates-v0.9.2 branch May 6, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants