Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit workflow. #128

Closed

Conversation

Drew-Kimberly
Copy link

@Drew-Kimberly Drew-Kimberly commented Jul 25, 2019

This PR:

  1. Adds php_codesniffer as a dev dependency.
  2. Updates run_phpcs.sh so that it will properly run PSR2 validation against the codebase.
  3. Updates run_phpunit.sh so that it will run the Unit test suite.
  4. Updates some documentation in README.md.

I'd like to include a pre-commit Git hook so that the pre_commit.sh script is automatically fired, but thought I'd ask first. Is this something you'd like included?

@jmglsn
Copy link
Member

jmglsn commented Jul 26, 2019

Hi @Drew-Kimberly,
thank you for your PR, actually we removed the codesniffer dependency in #123 and maybe we're also going to remove the pre-commit hooks, actually the checks should be configured at repository level instead.
Sorry, so there is no need to merge this PR.

@jmglsn jmglsn self-requested a review July 26, 2019 18:44
@jmglsn jmglsn self-assigned this Jul 26, 2019
@jmglsn jmglsn added the wontfix label Jul 26, 2019
@jmglsn jmglsn closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants