Fix emptyBuffer() handling #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no data is available, we should not update server activity timestamp. Instead, ask if something is going wrong. Fixes stomp-php#148 Due to stomp-php/stomp-php@3f35438
Nestorfish
force-pushed
the
fix-server-heartbeat
branch
from
4681b3d
to
33db2ba
Compare
|
Hi @Nestorfish, |
|
No problem, thanks again and good luck for your house! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no data is available, we should not update server activity timestamp.
Instead, ask if something is going wrong.
Fixes #148
Due to 3f35438