Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Code Refactor #48

Closed
gmallard opened this issue Jul 28, 2012 · 2 comments
Closed

Source Code Refactor #48

gmallard opened this issue Jul 28, 2012 · 2 comments

Comments

@gmallard
Copy link

The connection.rb and to a lesser extent client.rb source modules are beginning to reach an insane LOC number.

These modules need to be split into multiple source modules based on public / private method specifications and on what functionality is implemented.

Additionally at some point the entire source tree should be "beautified".

This seems to be a quiet time for the gem, and this effort can be started.

gmallard added a commit that referenced this issue Jul 29, 2012
gmallard added a commit that referenced this issue Jul 29, 2012
@gmallard
Copy link
Author

Expanding the scope of this to include:

  • Update all method comments.
  • Attempt to regularize use of parens in method definitions
  • In particular, comment the Stomp::Error classes
  • And comment the tests

@gmallard
Copy link
Author

Close, ref above commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant