Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sling-web-framework] Remove makeRequest from domHelper. #88

Open
caiomdias opened this issue Oct 17, 2018 · 0 comments
Open

[sling-web-framework] Remove makeRequest from domHelper. #88

caiomdias opened this issue Oct 17, 2018 · 0 comments
Assignees
@caiomdias
Labels
enhancement New feature or request hacktoberfest up for grabs

Comments

@caiomdias
Copy link
Contributor

caiomdias commented Oct 17, 2018 •
edited

I'm submitting a:

[ ] bug report
[x ] feature request
[ ] support request

Current behavior:

The makeRequest helper that is being exposed by domHelper does not make sense to remain in the project, but rather to be migrated to customer-js-sdk, its only client.
@caiomdias caiomdias added the enhancement New feature or request label Oct 17, 2018
@caiomdias caiomdias changed the title [sling-web-framework] Remove makeRequest from domHelpers. [sling-web-framework] Remove makeRequest from domHelper. Oct 17, 2018
@caiomdias caiomdias self-assigned this Oct 17, 2018
breakzplatform pushed a commit that referenced this issue Oct 17, 2018
Merge pull request #89 from stone-payments/issue#88
b894948 
Remove makeRequest helper from domHelper close Issue #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caiomdias caiomdias

Labels
enhancement New feature or request hacktoberfest up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@renanrbs @caiomdias