feat: Adds Makefile entry to generate rockspec file #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Por favor, catalogue-o seguindo as instruções nesta documentação. [Via VPN]. 💁 Qualquer dúvida, sinta-se à vontade para entrar em contato conosco no canal do Slack #backstage . |
jonathanlazaro1
requested review from
ALTbruno,
andremacdowell,
brennogb,
glauberatanaka,
guih50,
leoferlopes,
mauriciokb,
Miltonrdj and
Wuerike
as code owners
jonathanlazaro1
requested review from
asamedeiros,
andreals,
lucaslima-7 and
caiocanallipagarme
andreals
approved these changes
Nov 24, 2023
Wuerike
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simply adds a Makefile entry for generate the rockspec file directly (this was a duty of the
setupentry previously).How Has This Been Tested?
Given that:
setupentry still needs to create the rockspec filesetupis now calling the newrockspecentry itselfsetupentry is called during CI, a simply CI run is enough evidence that everything is working after this change.