Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix subquery of exists when use primary key (#971 #944) #1050

Closed
wants to merge 1 commit into from
Closed

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Dec 1, 2022

Summary about this PR

Issue Number: close #971 #944

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

This pull request's title should follow requirements next. @adofsauron please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (stonedb-5.7-dev@925f350). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 4528b38 differs from pull request most recent head ee37e0b. Consider uploading reports for the commit ee37e0b to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##             stonedb-5.7-dev   #1050   +/-   ##
=================================================
  Coverage                   ?       0           
=================================================
  Files                      ?       0           
  Lines                      ?       0           
  Branches                   ?       0           
=================================================
  Hits                       ?       0           
  Misses                     ?       0           
  Partials                   ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

    Reasons: The current primary key index is not supported for range queries
@zsp108 zsp108 added PR-bug bug for pull request and removed PR-bug bug for pull request labels Dec 1, 2022
@zsp108 zsp108 changed the title fix(tianmu): fix subquery of exists when use primary key (#971 #944) fix(tianmu): fix subquery of exists when use primary key (#971 #944) Dec 1, 2022
@mergify mergify bot added the PR-bug bug for pull request label Dec 1, 2022
@zsp108
Copy link
Contributor

zsp108 commented Dec 1, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

refresh

✅ Pull request refreshed

@adofsauron adofsauron closed this by deleting the head repository Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug:If the field you used in the join condition is primary key, using "EXISTS" will return wrong result.
4 participants