Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix query exists with primary key (#971 #944) #1053

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix(tianmu): fix query exists with primary key (#971 #944) #1053

merged 1 commit into from
Dec 2, 2022

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Dec 1, 2022

Summary about this PR

Issue Number: close #971 #944

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Dec 1, 2022
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 33.74% // Head: 33.74% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (9efb8fc) compared to base (f534557).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1053      +/-   ##
===================================================
- Coverage            33.74%   33.74%   -0.01%     
===================================================
  Files                 1807     1807              
  Lines               394958   394959       +1     
===================================================
- Hits                133264   133263       -1     
- Misses              261694   261696       +2     
Impacted Files Coverage Δ
storage/tianmu/core/descriptor.cpp 56.67% <100.00%> (-0.07%) ⬇️
storage/tianmu/core/descriptor.h 71.73% <100.00%> (+0.62%) ⬆️
storage/tianmu/index/tianmu_table_index.cpp 53.01% <0.00%> (-12.66%) ⬇️
storage/tianmu/index/kv_transaction.cpp 63.15% <0.00%> (-7.02%) ⬇️
storage/innobase/include/dict0priv.ic 70.58% <0.00%> (-5.89%) ⬇️
storage/tianmu/vc/single_column.h 83.72% <0.00%> (-4.66%) ⬇️
storage/tianmu/core/tianmu_attr_exqp.cpp 43.27% <0.00%> (-3.95%) ⬇️
storage/tianmu/index/rdb_meta_manager.cpp 69.29% <0.00%> (-3.84%) ⬇️
storage/tianmu/vc/virtual_column_base.h 59.21% <0.00%> (-1.32%) ⬇️
storage/innobase/dict/dict0load.cc 45.45% <0.00%> (-1.22%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RingsC RingsC self-requested a review December 2, 2022 06:18
@mergify mergify bot merged commit 7f96549 into stoneatom:stonedb-5.7-dev Dec 2, 2022
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

bug:If the field you used in the join condition is primary key, using "EXISTS" will return wrong result.
4 participants