Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix bug: The instance occasionally crashes if both fields … #1528

Merged

Conversation

wisehead
Copy link
Collaborator

@wisehead wisehead commented Apr 4, 2023

…specified for an equi-join are of the string data types (#1476)

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Apr 4, 2023
@wisehead wisehead force-pushed the bug1476_varchar_hash_join_crash branch from 7053ff6 to d3f8cdb Compare April 4, 2023 09:14
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (9d45726) 45.04% compared to head (042c607) 45.01%.

❗ Current head 042c607 differs from pull request most recent head 7c3c30a. Consider uploading reports for the commit 7c3c30a to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1528      +/-   ##
===================================================
- Coverage            45.04%   45.01%   -0.04%     
===================================================
  Files                 1999     1999              
  Lines               413916   413915       -1     
===================================================
- Hits                186450   186322     -128     
- Misses              227466   227593     +127     
Impacted Files Coverage Δ
storage/tianmu/core/parallel_hash_join.cpp 0.62% <ø> (+<0.01%) ⬆️

... and 74 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wisehead wisehead force-pushed the bug1476_varchar_hash_join_crash branch 3 times, most recently from 52e23b0 to 042c607 Compare April 6, 2023 01:43
Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…specified for an equi-join are of the string data types (stoneatom#1476)
@wisehead wisehead force-pushed the bug1476_varchar_hash_join_crash branch from 042c607 to 7c3c30a Compare April 6, 2023 08:16
@mergify mergify bot merged commit 03f5df2 into stoneatom:stonedb-5.7-dev Apr 6, 2023
@Nliver Nliver added this to the stonedb_5.7_v1.0.4 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

5 participants