Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mtr): To fix the mtr usage #1537

Merged
merged 1 commit into from
Apr 10, 2023
Merged

feat(mtr): To fix the mtr usage #1537

merged 1 commit into from
Apr 10, 2023

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Apr 10, 2023

The disabeld mtr use cases should follow the mtr conventional rules. Adds a disabled.def to indeciate which case is disabled or not.

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

The disabeld mtr use cases should follow the mtr conventional rules.
Adds a disabled.def to indeciate which case is disabled or not.
@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 90.90% and no project coverage change.

Comparison is base (e7bbe88) 45.00% compared to head (ca6c384) 45.00%.

Additional details and impacted files
@@               Coverage Diff                @@
##           stonedb-5.7-dev    #1537   +/-   ##
================================================
  Coverage            45.00%   45.00%           
================================================
  Files                 1999     1999           
  Lines               413913   413915    +2     
================================================
+ Hits                186283   186293   +10     
+ Misses              227630   227622    -8     
Impacted Files Coverage Δ
storage/tianmu/core/column_share.cpp 85.60% <ø> (ø)
storage/tianmu/core/pack.h 85.10% <ø> (ø)
storage/tianmu/core/parallel_hash_join.cpp 0.62% <ø> (+<0.01%) ⬆️
storage/tianmu/core/pack.cpp 62.26% <75.00%> (+1.47%) ⬆️
storage/tianmu/core/pack_str.cpp 64.22% <87.50%> (+0.29%) ⬆️
storage/tianmu/core/engine.cpp 48.26% <100.00%> (-3.05%) ⬇️
storage/tianmu/core/tianmu_attr.cpp 69.55% <100.00%> (ø)
storage/tianmu/core/tianmu_table.cpp 46.75% <100.00%> (+0.05%) ⬆️

... and 77 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RingsC RingsC marked this pull request as ready for review April 10, 2023 04:23
@RingsC
Copy link
Contributor Author

RingsC commented Apr 10, 2023

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 166f87a into stoneatom:stonedb-5.7-dev Apr 10, 2023
@RingsC RingsC deleted the fix-mtr-usage branch April 11, 2023 03:45
@Nliver Nliver added this to the stonedb_5.7_v1.0.4 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants