fix(tianmu): revert code, mv ret value from try block back to catch block. (#1532) #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock [summary] The logic of this modification is as follows: Previously, set ret action has been moved to try block, which is not efficient because every time we do truncate success, ret will be setted to 1. This time we will move the set ret action back to catch block, which will only trigged when truncate failed.
|
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
|
@Dysprosium0626 Thanks for your contribution, and pls sign the CLA at first. |
|
@RingsC thanks, I have completed signed the CLA |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1555 +/- ##
===================================================
- Coverage 45.14% 45.06% -0.09%
===================================================
Files 1999 1999
Lines 413931 413931
===================================================
- Hits 186873 186533 -340
- Misses 227058 227398 +340
... and 86 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Dysprosium0626
deleted the
mv_ret_value_from_try_block_back_to_catch_block_issue1532
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of this modification is as follows:
Previously, set ret action has been moved to try block, which is not efficient because every time we do truncate success, ret will be setted to 1. This time we will move the set ret action back to catch block, which will only trigged when truncate failed.
Summary about this PR
Issue Number: close #1532
Tests Check List
Changelog
Documentation