Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mtr): add more innodb testcases and tianmu range testcase(#1196) #1569

Merged
merged 1 commit into from Apr 17, 2023

Conversation

davidshiz
Copy link
Collaborator

Summary about this PR

Issue Number: ref #1196

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Apr 16, 2023

This pull request's title should follow requirements next. @davidshiz please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Apr 16, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@davidshiz davidshiz changed the title add more innodb testcases and tianmu range testcase(#1196) test(mtr): add more innodb testcases and tianmu range testcase(#1196) Apr 16, 2023
@mergify mergify bot added the PR-testing label Apr 16, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.4 milestone Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +10.03 🎉

Comparison is base (8e197ae) 45.15% compared to head (9e4141d) 55.18%.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1569       +/-   ##
====================================================
+ Coverage            45.15%   55.18%   +10.03%     
====================================================
  Files                 1999     2031       +32     
  Lines               413931   431336    +17405     
====================================================
+ Hits                186906   238042    +51136     
+ Misses              227025   193294    -33731     
Impacted Files Coverage Δ
storage/tianmu/core/table_share.h 77.77% <ø> (ø)
storage/tianmu/vc/column_share.cpp 85.60% <75.00%> (ø)
storage/tianmu/vc/column_share.h 100.00% <100.00%> (ø)
storage/tianmu/vc/tianmu_attr.cpp 74.04% <100.00%> (ø)

... and 738 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidshiz davidshiz requested review from wisehead, hustjieke, haitaoguan and adofsauron and removed request for adofsauron April 17, 2023 08:20
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
LGTM

@mergify mergify bot merged commit 09f0e40 into stoneatom:stonedb-5.7-dev Apr 17, 2023
9 checks passed
@davidshiz davidshiz deleted the mtr branch April 17, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants