Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(quickstart): add stonedb-8.0 compiling guide for CentOS 7.x #1756

Merged
merged 5 commits into from May 10, 2023
Merged

docs(quickstart): add stonedb-8.0 compiling guide for CentOS 7.x #1756

merged 5 commits into from May 10, 2023

Conversation

Xinqiangxu
Copy link
Collaborator

@Xinqiangxu Xinqiangxu commented May 9, 2023 •
edited

Summary about this PR

Issue Number: close #1753

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@CLAassistant
Copy link

CLAassistant commented May 9, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@mergify
Copy link
Contributor

mergify bot commented May 9, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-docs docs for pull request label May 9, 2023
@Xinqiangxu Xinqiangxu self-assigned this May 9, 2023
@Nliver Nliver self-requested a review May 9, 2023 08:01
@Nliver Nliver added this to the StoneDB_8.0_v1.0.1 milestone May 9, 2023
RingsC
RingsC approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks for your works.

@RingsC RingsC requested a review from hustjieke May 9, 2023 12:56
Nliver
Nliver requested changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that you update relevant documents in Chinese at the same time, otherwise, the Chinese page will display errors

...4-developer-guide/00-compiling-methods/compile-using-centos7/compile-using-centos7-for-80.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StoneDB except English documents, as well as Chinese documents, corresponding Chinese document directory in this article: website/i18n/zh/docusaurus-plugin-content-docs/current/02-getting-started/quick-deployment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that you update relevant documents in Chinese at the same time, otherwise, the Chinese page will display errors

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i have updated the Chinese docs

@Xinqiangxu
Merge branch 'stoneatom:stonedb-5.7-dev' into 1753-docsquickstart-add…
f0335be 
…-stonedb-80-compiling-guide-for-centos-7x
@Xinqiangxu
docs(quickstart): add stonedb-8.0 compiling guide(Chinese) for CentOS…
93db626 
… 7.x
@Xinqiangxu
Merge branch '1753-docsquickstart-add-stonedb-80-compiling-guide-for-…
455be60 
…centos-7x' of github.com:xxq-xu/stonedb into 1753-docsquickstart-add-stonedb-80-compiling-guide-for-centos-7x
Nliver
Nliver approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，good job~

@Nliver Nliver merged commit c4d2d2f into stoneatom:stonedb-5.7-dev May 10, 2023
2 checks passed
@Xinqiangxu Xinqiangxu deleted the 1753-docsquickstart-add-stonedb-80-compiling-guide-for-centos-7x branch May 26, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RingsC RingsC RingsC approved these changes

@Nliver Nliver Nliver approved these changes

@hustjieke hustjieke Awaiting requested review from hustjieke

Assignees

@Xinqiangxu Xinqiangxu

Labels
PR-docs docs for pull request
Projects
StoneDB for MySQL 8.0
Status: Done
Milestone
StoneDB_8.0_v1.0.1
Development

Successfully merging this pull request may close these issues.

docs(quickstart): add stonedb-8.0 compiling guide for CentOS 7.x
4 participants
@Xinqiangxu @CLAassistant @RingsC @Nliver