Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(developer-guide): update the compiling guide of StoneDB 8.0 for CentOS 7.x #1817 #1834

Merged
merged 2 commits into from
Jun 7, 2023
Merged

docs(developer-guide): update the compiling guide of StoneDB 8.0 for CentOS 7.x #1817 #1834

merged 2 commits into from
Jun 7, 2023

Conversation

Xinqiangxu
Copy link
Collaborator

@Xinqiangxu Xinqiangxu commented May 26, 2023 •
edited
Loading

Summary about this PR

Issue Number: close #1817

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@Xinqiangxu Xinqiangxu added the A-documentation Improvements or additions to documentation label May 26, 2023
@Xinqiangxu Xinqiangxu self-assigned this May 26, 2023
@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-docs docs for pull request label May 26, 2023
@Xinqiangxu
Copy link
Collaborator Author

This version of compiling guide is completely user-friendly.

Nliver
Nliver approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nliver Nliver requested review from haitaoguan and removed request for hustjieke June 7, 2023 10:39
@Nliver Nliver merged commit 9404338 into stoneatom:stonedb-5.7-dev Jun 7, 2023
2 checks passed
@Xinqiangxu Xinqiangxu deleted the 1817-docsdeveloper-guide-update-the-compiling-guide-of-stonedb80-on-centos7x branch July 1, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nliver Nliver Nliver approved these changes

@haitaoguan haitaoguan haitaoguan approved these changes

Assignees

@Xinqiangxu Xinqiangxu

Labels
A-documentation Improvements or additions to documentation PR-docs docs for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(developer-guide): update the compiling guide of StoneDB 8.0 for CentOS 7.x
3 participants
@Xinqiangxu @Nliver @haitaoguan