Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): fix when using where to filter hexadecimal format data, return incorrect(#1625) #1872

Merged
merged 1 commit into from Jul 19, 2023
Merged

fix(tianmu): fix when using where to filter hexadecimal format data, return incorrect(#1625) #1872

merged 1 commit into from Jul 19, 2023

Conversation

chenshengjiang
Copy link
Collaborator

@chenshengjiang chenshengjiang commented Jun 12, 2023 •
edited

Summary about this PR

Item_hex_string will be transformed to Item_int here eventually leading to wrong type of item in evaluation.
Only Item_hex_string and Comparison context is REAL_RESULT need transformation.

Issue Number: close #1625

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 12, 2023
@chenshengjiang chenshengjiang force-pushed the issue1625 branch 4 times, most recently from e224fc5 to 700f040 Compare July 10, 2023 11:53
@chenshengjiang
Copy link
Collaborator Author

100% new code coverage

@chenshengjiang
Copy link
Collaborator Author

image
All mtr tests passed.

@chenshengjiang chenshengjiang force-pushed the issue1625 branch 3 times, most recently from 8638848 to 9eb604f Compare July 18, 2023 02:02
@chenshengjiang
fix(tianmu): fix when using where to filter hexadecimal format data, …
cfaff7b 
…return incorrect(stoneatom#1625)

`Item_hex_string` will be transformed to `Item_int` here eventually leading to wrong type of item in evaluation.
Only `Item_hex_string` and Comparison context is `REAL_RESULT` need transformation.
davidshiz
davidshiz approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@davidshiz davidshiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RingsC RingsC merged commit 5e4461c into stoneatom:stonedb-5.7-dev Jul 19, 2023
3 of 5 checks passed
@chenshengjiang chenshengjiang deleted the issue1625 branch July 19, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RingsC RingsC RingsC approved these changes

@davidshiz davidshiz davidshiz approved these changes

@zhongshengstoneatom zhongshengstoneatom Awaiting requested review from zhongshengstoneatom

Assignees

@chenshengjiang chenshengjiang

Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: When using where to filter hexadecimal formate data, return incorrect
3 participants
@chenshengjiang @RingsC @davidshiz