Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix UNION of non-matching columns and express with aggregation (#1861 #1864 #1873 #1870) #1881

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Jun 14, 2023

修改的代码逻辑

  1. 当包含表达式的投影的聚合在处理时, 存在聚合为空的情况, 此时需要进行表达式计算
  2. 当创建临时表时, decimal的精度存在校验, 但是这里的校验与物理表不一致, 而且没有对后续的逻辑产生正当作用, 具体看mtr测试的场景

Summary about this PR

Issue Number: close #1861 #1864 #1873 #1870

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 14, 2023
@adofsauron adofsauron changed the title fix(tianmu): fix UNION of non-matching columns and express with aggregation (#1861 #1864 #1873) fix(tianmu): fix UNION of non-matching columns and express with aggregation (#1861 #1864 #1873 #1870) Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.02 ⚠️

Comparison is base (6b369e5) 55.17% compared to head (382bb32) 55.15%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1881      +/-   ##
===================================================
- Coverage            55.17%   55.15%   -0.02%     
===================================================
  Files                 2031     2031              
  Lines               431521   431521              
===================================================
- Hits                238085   238016      -69     
- Misses              193436   193505      +69     
Impacted Files Coverage Δ
storage/tianmu/core/temp_table.cpp 74.64% <ø> (+1.70%) ⬆️
storage/tianmu/optimizer/aggregation_algorithm.cpp 56.28% <83.33%> (+0.32%) ⬆️
storage/tianmu/core/engine_execute.cpp 58.56% <100.00%> (ø)
storage/tianmu/core/query_compile.cpp 65.36% <100.00%> (+0.90%) ⬆️

... and 86 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adofsauron adofsauron removed their assignment Jun 14, 2023
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@zhongshengstoneatom zhongshengstoneatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

various_join.test should be changed to guarantee a stable result

@mergify mergify bot merged commit f180323 into stoneatom:stonedb-5.7-dev Jun 15, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: 包含内连接和外连接及派生表和子查询的查询结果错误
3 participants