Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): To suuport ignore option for update statement #1884

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix(tianmu): To suuport ignore option for update statement #1884

merged 1 commit into from
Jun 20, 2023

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Jun 14, 2023

Summary about this PR

To support update ignore statement. The logic of uniqueness check is re-implemented.
Issue Number: close #1616

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.21 🎉

Comparison is base (9939611) 55.03% compared to head (7e67135) 55.25%.

❗ Current head 7e67135 differs from pull request most recent head aeb1ce2. Consider uploading reports for the commit aeb1ce2 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1884      +/-   ##
===================================================
+ Coverage            55.03%   55.25%   +0.21%     
===================================================
  Files                 2031     2031              
  Lines               431521   431536      +15     
===================================================
+ Hits                237506   238460     +954     
+ Misses              194015   193076     -939     
Impacted Files Coverage Δ
storage/tianmu/core/engine.cpp 64.18% <0.00%> (+15.56%) ⬆️
storage/tianmu/core/table_share.h 77.77% <ø> (ø)
storage/tianmu/core/tianmu_table.cpp 68.39% <ø> (+20.52%) ⬆️
storage/tianmu/handler/ha_tianmu.h 81.25% <ø> (ø)
storage/tianmu/index/tianmu_table_index.h 42.85% <ø> (ø)
storage/tianmu/vc/tianmu_attr.h 73.62% <ø> (ø)
storage/tianmu/core/engine.h 30.76% <50.00%> (+1.60%) ⬆️
storage/tianmu/vc/tianmu_attr.cpp 74.23% <82.35%> (+4.78%) ⬆️
storage/tianmu/index/tianmu_table_index.cpp 56.57% <93.75%> (+0.50%) ⬆️
storage/tianmu/core/table_share.cpp 84.74% <100.00%> (+0.26%) ⬆️
... and 1 more

... and 85 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RingsC RingsC marked this pull request as ready for review June 14, 2023 13:08
Copy link

@zhongshengstoneatom zhongshengstoneatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To support `update ignore` statement. The logic of uniqueness check is re-implemented.
@mergify mergify bot merged commit d7584f1 into stoneatom:stonedb-5.7-dev Jun 20, 2023
6 of 7 checks passed
@RingsC RingsC deleted the fix-issue-1616-update-ignore branch June 20, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: update ignore return incorrect result set
3 participants