Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tianmu): add order by sentence in the mtr case various_join.test #1886

Merged
merged 1 commit into from Jun 16, 2023

Conversation

Xinqiangxu
Copy link
Collaborator

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 15, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Copy link

@zhongshengstoneatom zhongshengstoneatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.07 ⚠️

Comparison is base (6b369e5) 55.17% compared to head (910beaa) 55.10%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1886      +/-   ##
===================================================
- Coverage            55.17%   55.10%   -0.07%     
===================================================
  Files                 2031     2031              
  Lines               431521   431521              
===================================================
- Hits                238085   237805     -280     
- Misses              193436   193716     +280     
Impacted Files Coverage Δ
storage/tianmu/core/temp_table.cpp 74.64% <ø> (+1.70%) ⬆️
storage/tianmu/optimizer/aggregation_algorithm.cpp 56.28% <83.33%> (+0.32%) ⬆️
storage/tianmu/core/engine_execute.cpp 58.56% <100.00%> (ø)
storage/tianmu/core/query_compile.cpp 65.36% <100.00%> (+0.90%) ⬆️

... and 96 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit 798ca7a into stoneatom:stonedb-5.7-dev Jun 16, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants