Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): default value of the field take unaffect in load #1865 #1896

Merged
merged 2 commits into from Jun 26, 2023
Merged

fix(tianmu): default value of the field take unaffect in load #1865 #1896

merged 2 commits into from Jun 26, 2023

Conversation

Double0101
Copy link
Collaborator

Cause:
in the function ParsingStrategy::ParseResult ParsingStrategy::GetOneRow
field->val_str(str) cannot distinguish 0 and NULL value. Solution:
Check whether field's default value is NULL.

Summary about this PR

Issue Number: close #1865

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@Double0101 Double0101 self-assigned this Jun 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 19, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and project coverage change: -5.12 ⚠️

Comparison is base (7d03695) 60.25% compared to head (d096d0f) 55.13%.

❗ Current head d096d0f differs from pull request most recent head 52c072d. Consider uploading reports for the commit 52c072d to get more accurate results

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1896      +/-   ##
===================================================
- Coverage            60.25%   55.13%   -5.12%     
===================================================
  Files                 1837     2031     +194     
  Lines               380678   431524   +50846     
===================================================
+ Hits                229371   237926    +8555     
- Misses              151307   193598   +42291
Impacted Files Coverage Δ
storage/tianmu/loader/parsing_strategy.cpp 70.11% <100.00%> (+0.25%) ⬆️

... and 274 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Double0101
fix(tianmu): default value of the field take unaffect in load stoneat…
d096d0f 
…om#1865

Cause:
  in the function ParsingStrategy::ParseResult ParsingStrategy::GetOneRow
field->val_str(str) cannot distinguish 0 and NULL value.
Solution:
  Check whether field's default value is NULL.
zhongshengstoneatom
zhongshengstoneatom approved these changes Jun 20, 2023
View reviewed changes
Copy link

@zhongshengstoneatom zhongshengstoneatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RingsC
RingsC approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 73dcfec into stoneatom:stonedb-5.7-dev Jun 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RingsC RingsC RingsC approved these changes

@zhongshengstoneatom zhongshengstoneatom zhongshengstoneatom approved these changes

Assignees

@Double0101 Double0101

Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: load data , the default value of the field does not take effect
3 participants
@Double0101 @RingsC @zhongshengstoneatom