Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): incorrect result when using where expr and args > bigint_max #1564 #1902

Merged
merged 1 commit into from Jun 29, 2023

Conversation

Double0101
Copy link
Collaborator

[summary]

  1. static_cast<int64_t>(18446744073709551601) = -15
  2. Item will set 18446744073709551601 with unsigned flag, but in tianmu transform to ValueOrNot, the value will be set to -15.
  3. add unsigned flag in value_or_null & TianmuNum & tianmu expr.

Summary about this PR

Issue Number: close #1564

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 79.11% and project coverage change: +5.17 🎉

Comparison is base (6b369e5) 55.17% compared to head (90a7de6) 60.34%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1902      +/-   ##
===================================================
+ Coverage            55.17%   60.34%   +5.17%     
===================================================
  Files                 2031     1837     -194     
  Lines               431521   380703   -50818     
===================================================
- Hits                238085   229753    -8332     
+ Misses              193436   150950   -42486     
Impacted Files Coverage Δ
storage/tianmu/core/engine.cpp 64.25% <0.00%> (-3.13%) ⬇️
storage/tianmu/core/just_a_table.h 100.00% <ø> (ø)
storage/tianmu/core/query_compile.cpp 65.48% <ø> (+1.02%) ⬆️
storage/tianmu/core/table_share.h 77.77% <ø> (ø)
storage/tianmu/core/temp_table.h 58.33% <ø> (ø)
storage/tianmu/core/tianmu_table.cpp 68.39% <ø> (+1.01%) ⬆️
storage/tianmu/handler/ha_tianmu.h 81.25% <ø> (ø)
storage/tianmu/index/tianmu_table_index.h 42.85% <ø> (ø)
storage/tianmu/optimizer/aggregator_basic.h 63.45% <ø> (+9.34%) ⬆️
storage/tianmu/optimizer/compile/compiled_query.h 72.00% <ø> (ø)
... and 36 more

... and 299 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…_max stoneatom#1564

[summary]
1. static_cast<int64_t>(18446744073709551601) = -15
2. Item will set 18446744073709551601 with unsigned flag, but in tianmu
transform to ValueOrNot, the value will be set to `-15`.
3. add `unsigned flag` in value_or_null & TianmuNum & tianmu expr.
@mergify mergify bot merged commit 6349898 into stoneatom:stonedb-5.7-dev Jun 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: bigint type, return wrong result;
4 participants