Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow(codecov): Filter out excess code files #1905

Merged
merged 1 commit into from Jun 25, 2023

Conversation

Nliver
Copy link
Collaborator

@Nliver Nliver commented Jun 25, 2023

Summary about this PR

Filter out excess code files

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@Nliver Nliver self-assigned this Jun 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2023

This pull request's title should follow requirements next. @Nliver please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@Nliver Nliver changed the title wokflow(codecov): Filter out excess code files workflow(codecov): Filter out excess code files Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.95 🎉

Comparison is base (5606c87) 55.29% compared to head (f8b63e0) 60.24%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1905      +/-   ##
===================================================
+ Coverage            55.29%   60.24%   +4.95%     
===================================================
  Files                 2031     1837     -194     
  Lines               431536   380678   -50858     
===================================================
- Hits                238605   229347    -9258     
+ Misses              192931   151331   -41600     

see 270 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@davidshiz davidshiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@mergify mergify bot merged commit 186f694 into stoneatom:stonedb-5.7-dev Jun 25, 2023
8 of 9 checks passed
@Nliver Nliver linked an issue Jun 26, 2023 that may be closed by this pull request
3 tasks
@Nliver Nliver deleted the update-codecov-filter branch June 26, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Two WokFlows failed under Actions
3 participants