Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): To remove unnessary optimization in tianmu #1911

Merged
merged 1 commit into from Jun 28, 2023
Merged

fix(tianmu): To remove unnessary optimization in tianmu #1911

merged 1 commit into from Jun 28, 2023

Conversation

RingsC
Copy link
Contributor

@RingsC RingsC commented Jun 27, 2023

Summary about this PR

Removes the unnessary optimization in stage of compiliation of tianmu. It doesnot have any helps for us. and may introuduce unexepected behaviors.

Issue Number: close #1861

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jun 27, 2023
1:Removes the unnessary optimization in stage of compiliation of tianmu. It doesnot have any helps for us.
and may introuduce unexepected behaviors.
2:Refine MTR: issue848, issue1865, alter_table1, issue1523
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.29 ⚠️

Comparison is base (a4600c4) 60.33% compared to head (cc3d5b7) 60.04%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1911      +/-   ##
===================================================
- Coverage            60.33%   60.04%   -0.29%     
===================================================
  Files                 1837     1837              
  Lines               380674   380671       -3     
===================================================
- Hits                229672   228591    -1081     
- Misses              151002   152080    +1078     
Impacted Files Coverage Δ
storage/tianmu/core/query_compile.cpp 65.48% <ø> (-0.18%) ⬇️

... and 133 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RingsC RingsC marked this pull request as ready for review June 28, 2023 05:21
@mergify mergify bot merged commit 6a560a0 into stoneatom:stonedb-5.7-dev Jun 28, 2023
8 of 9 checks passed
@RingsC RingsC deleted the fix-issue-1861-left-join-crash branch June 28, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: 包含内连接和外连接及派生表和子查询的查询结果错误
3 participants