Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu):Delta layer, add the command to view the playback progress(5.7) #1930

Merged
merged 10 commits into from Oct 17, 2023
Merged

feat(tianmu):Delta layer, add the command to view the playback progress(5.7) #1930

merged 10 commits into from Oct 17, 2023

Conversation

streakyPorker
Copy link
Contributor

@streakyPorker streakyPorker commented Jul 6, 2023 •
edited

Summary about this PR

Issue Number: close #1359
Implementation:

  1. modify sql_yacc.yy to support layer name and table list specification.
  2. modify tianmu_show_status method to handler the layer info query(currently only the playback process of delta layer is implemented)
  3. add mtr test & result

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Jul 6, 2023
@streakyPorker streakyPorker reopened this Jul 6, 2023
@streakyPorker streakyPorker changed the title feat(tianmu):Delta layer, add the command to view the playback progress(5.7) #1359 feat(tianmu):Delta layer, add the command to view the playback progress(5.7) Jul 6, 2023
@streakyPorker streakyPorker marked this pull request as ready for review July 7, 2023 01:47
@Nliver Nliver self-requested a review October 11, 2023 01:56
Nliver
Nliver approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nliver Nliver merged commit c2bd7f7 into stoneatom:stonedb-5.7-dev Oct 17, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nliver Nliver Nliver approved these changes

Assignees

@streakyPorker streakyPorker

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Delta layer, add the command to view the playback progress
3 participants
@streakyPorker @CLAassistant @Nliver