Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): fix up assert failed on cur_pack != nullptr when using group by on empty temp table (#1912) #1958

Merged
merged 1 commit into from Jul 20, 2023
Merged

fix(tianmu): fix up assert failed on cur_pack != nullptr when using group by on empty temp table (#1912) #1958

merged 1 commit into from Jul 20, 2023

Conversation

Xinqiangxu
Copy link
Collaborator

@Xinqiangxu Xinqiangxu commented Jul 19, 2023 •
edited

Summary about this PR

Issue Number: close #1912

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jul 19, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jul 19, 2023
@Xinqiangxu
Copy link
Collaborator Author

100% new code coverage

@Xinqiangxu
Copy link
Collaborator Author

image

@RingsC RingsC merged commit 98a2591 into stoneatom:stonedb-5.7-dev Jul 20, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RingsC RingsC RingsC approved these changes

@haitaoguan haitaoguan haitaoguan approved these changes

@zhongshengstoneatom zhongshengstoneatom Awaiting requested review from zhongshengstoneatom

Assignees
No one assigned
Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ERROR 1105 (HY000): assert failed on cur_pack != nullptr at tianmu_attr.cpp:427, msg: [Pack ptr is null]
3 participants
@Xinqiangxu @RingsC @haitaoguan