Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): the instance crashed while exporting data (#1961) #1964

Open
wants to merge 3 commits into
base: stonedb-5.7-dev
Choose a base branch
from

Conversation

TomeC
Copy link
Contributor

@TomeC TomeC commented Aug 21, 2023

Summary about this PR

Issue Number: close #1961

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Aug 21, 2023
@TomeC
Copy link
Contributor Author

TomeC commented Oct 11, 2023

@Nliver StoneDB Compile & MTR failed, reason:

This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

@Nliver
Copy link
Collaborator

Nliver commented Nov 23, 2023

@Nliver StoneDB Compile & MTR failed, reason:

This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

Thanks a lot, We will check this issue and fix it~

@Nliver
Copy link
Collaborator

Nliver commented Nov 27, 2023

@Nliver StoneDB Compile & MTR failed, reason:

This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

Hello, our Github Action has been restored~

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (6a560a0) 60.23% compared to head (5c4dad0) 60.07%.
Report is 28 commits behind head on stonedb-5.7-dev.

Files Patch % Lines
storage/tianmu/core/tianmu_table.cpp 5.55% 17 Missing ⚠️
storage/tianmu/handler/ha_tianmu.cpp 0.00% 9 Missing ⚠️
storage/tianmu/core/engine.cpp 53.33% 7 Missing ⚠️
storage/tianmu/loader/load_parser.cpp 55.55% 4 Missing ⚠️
sql/sql_yacc.yy 0.00% 3 Missing ⚠️
storage/tianmu/optimizer/aggregator_basic.cpp 40.00% 3 Missing ⚠️
storage/tianmu/core/value_or_null.cpp 77.77% 2 Missing ⚠️
storage/tianmu/vc/multi_value_column.h 0.00% 2 Missing ⚠️
sql/binlog.cc 0.00% 1 Missing ⚠️
storage/tianmu/core/item_tianmu_field.cpp 80.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1964      +/-   ##
===================================================
- Coverage            60.23%   60.07%   -0.17%     
===================================================
  Files                 1837     1837              
  Lines               380671   380786     +115     
===================================================
- Hits                229316   228744     -572     
- Misses              151355   152042     +687     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomeC
Copy link
Contributor Author

TomeC commented Nov 30, 2023

codecov/project Failing, But according to the prompts, I did not modify those files.

@Nliver
Copy link
Collaborator

Nliver commented Nov 30, 2023

codecov/project Failing, But according to the prompts, I did not modify those files.

We are checking what caused it and fixing the problem later~

Copy link
Contributor

mergify bot commented Mar 26, 2024

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: The instance crashed while exporting data
2 participants