Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ES6 example to readme #49

Merged
merged 3 commits into from
May 30, 2022
Merged

Added ES6 example to readme #49

merged 3 commits into from
May 30, 2022

Conversation

rukshn
Copy link
Contributor

@rukshn rukshn commented May 26, 2022

Updated the readme English by adding ES6 example

@codecov-commenter
Copy link

Codecov Report

Merging #49 (0108def) into master (984642f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files          55       55           
  Lines        1060     1060           
  Branches      279      279           
=======================================
  Hits         1024     1024           
  Misses         34       34           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984642f...0108def. Read the comment docs.

Copy link
Owner

@stonehank stonehank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please keep one example, like this,

const html2md=require('html-to-md')
// or
import html2md from 'html-to-md'

console.log(html2md('<strong><em>strong and italic</em></strong>',options))
// ***strong and italic***

Could you also commit the Chinese version changes which are the same as the English version, thanks

@rukshn
Copy link
Contributor Author

rukshn commented May 26, 2022

Yes sure, that's better, I'll make the changes and commit

@rukshn rukshn requested a review from stonehank May 30, 2022 11:40
Copy link
Owner

@stonehank stonehank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much

@stonehank stonehank merged commit a120f43 into stonehank:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants