Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster Spell Duplication #206

Closed
Sulan2 opened this issue May 30, 2023 · 4 comments
Closed

Faster Spell Duplication #206

Sulan2 opened this issue May 30, 2023 · 4 comments
Assignees
@stoneharry
Labels
enhancement

Comments

@Sulan2
Copy link

Sulan2 commented May 30, 2023

Hey Harry, would love if it was possible to right click in the scroll area on a spell and choose "create new spell from this spell" and then just write the new spell ID of the new spell.
@stoneharry
Copy link
Owner

Yeah this should behave the same way as the visual tab where you can right click kits/effects to perform actions on them (copy / paste / delete / new) and each action should not refresh the entire spell list.

There is a fair bit of technical debt with the spell selection list. This is something that I have been meaning to do for a long time but I need to sit down with a few hours free time and the motivation to actually do it. :)

@stoneharry stoneharry mentioned this issue Aug 5, 2023
Merged
9 tasks
@stoneharry stoneharry self-assigned this Aug 5, 2023
stoneharry added a commit that referenced this issue Aug 5, 2023
@stoneharry
#206 Spell List Refactor (making spell creation easier) (#213)
def35d4 
Make spell creation a lot easier by improving the spell selection list.

Adds context menu support to the spell selection list, for duplicating and deleting spells quickly.

Also allows for the list to be updated instead of fully rebuilt each time an operation is performed.

Also includes performance improvements for DBC export in the UI by prioritising the spell.dbc.
@stoneharry
Copy link
Owner

#213 Fixes this.

@stoneharry
Copy link
Owner

Fixed in release build v2.2.0.

@Sulan2
Copy link
Author

Sulan2 commented Aug 7, 2023

Absolute game changer, thank you so much @stoneharry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stoneharry stoneharry

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stoneharry @Sulan2