Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Add size and description in "My shares" list. #164

Closed
zikapanam opened this issue Jun 9, 2023 · 7 comments
Closed

馃殌 Feature: Add size and description in "My shares" list. #164

zikapanam opened this issue Jun 9, 2023 · 7 comments
Assignees
Labels
feature New feature or request

Comments

@zikapanam
Copy link

馃敄 Feature description

image
I would like pingvin-share to display size and description as well of the share in "My shares" list.

馃帳 Pitch

I think it could be useful to handle user space quota when it will be implemented. Also, the description is useful to know if a share can be safely removed or has be still shared.

@zikapanam zikapanam added the feature New feature or request label Jun 9, 2023
@pierrbt
Copy link
Contributor

pierrbt commented Jun 23, 2023

Hello @zikapanam, I'm starting working on this

@pierrbt
Copy link
Contributor

pierrbt commented Jun 23, 2023

First preview :
image
image

@stonith404, I've already talked about it in the discussions, but the share object only contains limited information, can you explain me why ? :

{
    "id": "M3Njk1N",
    "expiration": "2023-07-01T14:16:18.935Z",
    "description": "Hello les petits potes",
    "views": 0,
    "createdAt": "2023-06-23T14:56:29.167Z",
    "recipients": []
}

@pierrbt
Copy link
Contributor

pierrbt commented Jun 24, 2023

This is what this new feature looks like. Tell me what you think about it (@zikapanam @stonith404) :
image
image
image

If you are ok with this design I'll make a PR.

@pierrbt
Copy link
Contributor

pierrbt commented Jun 25, 2023

@zikapanam, the feature will be merged soon, following the #174 pr. But we'll have to wait the next release to have it on stable platforms

@pierrbt
Copy link
Contributor

pierrbt commented Jun 26, 2023

Merged in #174, the issue can be closed

@stonith404 stonith404 added the waiting-for-release Fixed or added and will be added to the next release label Jun 27, 2023
@stonith404
Copy link
Owner

I'll close this as soon as it is released. I think next week I should have time to release this.

@pierrbt
Copy link
Contributor

pierrbt commented Jul 21, 2023

This can be closed

@stonith404 stonith404 removed the waiting-for-release Fixed or added and will be added to the next release label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants