Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reverse" shares (URL for file upload) #43

Closed
stautonico opened this issue Dec 12, 2022 · 14 comments · Fixed by #86
Closed

"Reverse" shares (URL for file upload) #43

stautonico opened this issue Dec 12, 2022 · 14 comments · Fixed by #86
Assignees
Labels
feature New feature or request

Comments

@stautonico
Copy link
Contributor

A feature that I would really like to see is the ability to generate a URL which allows for a one time file upload. This could be used in cases where you want someone to send you a file, but it is large so hard to send over discord/email.

It would work as such:

  1. The authenticated user generates a URL that leads to a file upload. (can have expiration, use count, etc.)
  2. The user sends the link to someone
  3. The other person can upload a file (ability to limit to specific size/mime type/file count, etc)
  4. The authenticated user can view all the files uploaded to that specific URL via the shares dashboard, or possibly another dashboard.

This feature should be limited to authenticated users only.

This missing feature is the only thing stopping me from deploying this on my own server, and I would love to see it.

If this is something that you would like implemented into the program, I don't mind doing it myself and opening a PR.

@stonith404
Copy link
Owner

This feature sound really interesting! When we would have this feature, do think we would even need the feature that unauthenticated users can create shares anymore?
If you want you are very welcome to work on it, I could probably work on this feature too but currently I'm really busy until Christmas.

@stonith404 stonith404 added the feature New feature or request label Dec 12, 2022
@mztiq
Copy link

mztiq commented Dec 12, 2022

I'd love to see this implemented too ....wish I could contribute, but I'm no dev.

@stautonico
Copy link
Contributor Author

do think we would even need the feature that unauthenticated users can create shares anymore?

I think it would be a good idea to give users the choice: do they want anyone to be able to create shares, or do they only want some users to create shares, and maybe only once, like my proposed feature would implement.

I am very busy as well as finals week is coming up soon. Perhaps we can put this feature on the back burner until then?

@stonith404
Copy link
Owner

@stautonico Sure, because this is a big feature.

@github-actions github-actions bot added the stale label Jan 12, 2023
Repository owner deleted a comment from github-actions bot Jan 12, 2023
@stonith404 stonith404 removed the stale label Jan 12, 2023
@mztiq
Copy link

mztiq commented Jan 19, 2023

Sorry for being impatient, just wanted to check up on this and see if you guys already have plans when this feature might get implemented?

@stonith404
Copy link
Owner

@mztiq This is a really big feature, but this will be the next issue I want to implement. Looking forward to implement this ASAP, when I have some free time:)

@stonith404 stonith404 self-assigned this Jan 20, 2023
@mztiq
Copy link

mztiq commented Jan 20, 2023

Awesome, thanks for the quick reply!

@stonith404 stonith404 linked a pull request Jan 24, 2023 that will close this issue
@stonith404
Copy link
Owner

I think I'm almost finished. Could you guys give me some feedback? Here is a demo video #86 .

@mztiq
Copy link

mztiq commented Jan 24, 2023

Wow, this looks awesome and is going to make things so much easier for my use cases.
I have one question: Would it be possible for the creator to receive a (E-mail) notification once an unauthenticated user uploaded files to the share? This would be really neat.
Other than that I can't wait to test this feature myself.

Thanks again for your quick work!

@stonith404
Copy link
Owner

@mztiq Thanks for your feedback :) That's a good suggestion, I'll look into it.

@stonith404
Copy link
Owner

@mztiq Do you think it's necessary that the user can configure the subject and message of this email notification?

@stautonico
Copy link
Contributor Author

@stonith404 In my opinion, its not a super useful feature, but its probably not that hard to implement so may be worth considering.

@stonith404
Copy link
Owner

Added in v0.8.0 :)

@mztiq
Copy link

mztiq commented Jan 27, 2023

Just tested it, works like a charm.
Thanks again for implementing this 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants