Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Mail Notification #46

Closed
mztiq opened this issue Dec 12, 2022 · 12 comments
Closed

Customizable Mail Notification #46

mztiq opened this issue Dec 12, 2022 · 12 comments
Labels
feature New feature or request

Comments

@mztiq
Copy link

mztiq commented Dec 12, 2022

Hey,

really love pingvin and the feature to send mail notifications for shares.
Any chance we could define that notification message ourselves in a text box or something?

@stonith404 stonith404 added the feature New feature or request label Dec 12, 2022
@stonith404
Copy link
Owner

Good idea👍 This feature is not on the top of priority list, but will get implemented.

@stonith404
Copy link
Owner

Added in 0616a68 :) This allows you to set the mail message in the config section. This will get released in the next release.

@stonith404 stonith404 added the waiting-for-release Fixed or added and will be added to the next release label Dec 15, 2022
@mztiq
Copy link
Author

mztiq commented Dec 15, 2022

Wow, that was pretty quick for "not on top of the priority list". Thank you very much 😊.

@mztiq
Copy link
Author

mztiq commented Dec 23, 2022

Sorry for the late reply, I just had time to test this feature (which works great btw) but I noticed that it would be quite handy to be able to customize the subject of the mail notification too.
In my case all of my users are German and some don't speak English very well so right now I'd have a mix of English subject and German mail content. Any chance of getting a customizable subject too and if so should I create a new issue for that?

@stonith404 stonith404 reopened this Dec 23, 2022
@stonith404
Copy link
Owner

Ah yeah sure, completely forgot that. I've added another config variable cabaee5. I don't release this at the moment because the config table gets now really messy with so many configuration options. I'll officially release this when I've optimized the config page #60 .

But I've made a Docker image for you where I already added the subject config variable: stonith404/pingvin-share:pre-release

@mztiq
Copy link
Author

mztiq commented Dec 23, 2022

Nice, thank you very much!

@stonith404
Copy link
Owner

Added in v0.5.0 :)

@mztiq
Copy link
Author

mztiq commented Dec 30, 2022

Are you sure it's added in v0.5.0?

It looked like this with the stonith404/pingvin-share:pre-release:
grafik

And this is from v.0.5.0, the EMAIL_SUBJECT option is missing for me:
grafik

@stonith404
Copy link
Owner

Yeah but the problem is that for some reason the build pipeline takes 1 hour. Could you try to pull again?

@mztiq
Copy link
Author

mztiq commented Dec 30, 2022

Just pulled again, the EMAIL_SUBJECT option is there now.
Thanks.

@Hukuma1
Copy link

Hukuma1 commented Jan 31, 2023

Right now the name it uses as sender is Pingvin Share <myemail@mydomain.com>. Could we possibly also get that to be editable? Don't want to confuse my e-mail contacts (as cute as the name of this project is). :D

Also since we already have nice variable like {shareUrl}. Can we please also add {desc} (for the description of share) and {fileList} of the list of files and sizes? And {expires} could show when it would expire. This would bring it on parity with WeTransfer sent e-mails even more I believe. And this way you could personalize the e-mail subject even more by having the {desc} in it, for example.

@stonith404
Copy link
Owner

@Hukuma1 In case of the name in the email, I've just created an issue that would implement this (#93).
Could you create a separate issue for the extension of the email message variables?

@stonith404 stonith404 removed the waiting-for-release Fixed or added and will be added to the next release label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants