Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name property to share #462

Merged
merged 4 commits into from May 3, 2024
Merged

feat: add name property to share #462

merged 4 commits into from May 3, 2024

Conversation

stonith404
Copy link
Owner

@stonith404 stonith404 commented May 1, 2024

This pull request adds the ability to define the name of a share.

It can be added while starting the upload:
Screenshot 2024-05-03 at 18 02 02@2x

And it will be displayed on the share page
Screenshot 2024-05-03 at 18 02 21@2x

...and on on the "My Shares" page:
Screenshot 2024-05-03 at 18 03 56@2x

Closes #430

@stonith404 stonith404 marked this pull request as ready for review May 3, 2024 15:08
@stonith404 stonith404 merged commit b717663 into main May 3, 2024
3 checks passed
@stonith404 stonith404 deleted the feature/share-name branch May 3, 2024 15:20
@droplinxuser
Copy link

Does it matter if I allow Guest upload?
I cannot upload a file with Name set.

I got "500 (Internal Server Error)" with this error:
image

@stonith404
Copy link
Owner Author

Can you please create a bug report with the server logs and the exact reproduction steps?

@droplinxuser
Copy link

Can you please create a bug report with the server logs and the exact reproduction steps?

Please let me know if you need more information.
#466 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Decouple share name from URL token
2 participants