Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation UI tweaks part 2 #279

Closed
XVincentX opened this issue Mar 2, 2020 · 0 comments
Closed

Validation UI tweaks part 2 #279

XVincentX opened this issue Mar 2, 2020 · 0 comments
Labels

Comments

@XVincentX
Copy link

@marcelltoth @XVincentX I think this looks good for now though I don't think the error/warning message needs to be italic. Does it look bad if they're normal font?

I'm still leaning towards a flat list UI similar to what we're doing with the Spectral lint results. We could show the errors/warnings on the specific property lines within the code view too. We can do this later on when Studio supports "request" files though.

image

image

We should also consolidate the background colors of the "apply changes" UI in Studio with the validations background. https://github.com/stoplightio/platform-internal/blob/474c91635f611b8de60197f696824f9acad36e7a/packages/studio/src/components/ReadPanel/MarkdownComponents.tsx#L226-L238

image

Originally posted by @lottamus in #271 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants